chore: Remove SentryFrameTracker imports #5276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaybre
requested review from
alwx,
antonis and
lucas-zimerman
as code owners
Contributor
Android (new) Performance metrics 🚀
|
Contributor
Android (legacy) Performance metrics 🚀
|
noahsmartin
force-pushed
the
itay/frames_tracker_swift
branch
from
e060ba9 to
d61ca6d
Compare
noahsmartin
force-pushed
the
itay/frames_tracker_swift
branch
from
c9f86eb to
0327771
Compare
noahsmartin
force-pushed
the
itay/frames_tracker_swift
branch
from
e127486 to
b407fd2
Compare
# Conflicts: # packages/core/ios/RNSentry.mm
…wift # Conflicts: # packages/core/RNSentryCocoaTester/RNSentryCocoaTester.xcodeproj/project.pbxproj # packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m # packages/core/ios/RNSentry.mm # packages/core/ios/RNSentryDependencyContainer.m # packages/core/ios/SentrySDKWrapper.h # packages/core/ios/SentrySDKWrapper.m
10 tasks
Contributor
iOS (new) Performance metrics 🚀
|
Contributor
iOS (legacy) Performance metrics 🚀
|
10 tasks
antonis
approved these changes
Nov 11, 2025
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
LGTM 🚀
I'll proceed with merging in cocoa-v9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This PRs removes SentryFramesTracker.h imports removed in getsentry/sentry-cocoa#6447 and updates the code to use the Swift version.
💡 Motivation and Context
Relates to getsentry/sentry-cocoa#6447
This can only be merged once #5153, #5267 are merged and sentry-cocoa v9 is released.